Some minor optimizations and refactors #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
reviewed
Jun 14, 2022
|
Will take one more pass in the AM tomorrow |
|
Can you update the PR summary to include the changes you've made and the motivation for doing so? |
cygaar
reviewed
Jun 14, 2022
contracts/ERC721A.sol
Outdated
| /** | ||
| * @dev Casts the boolean to uint256 without branching. | ||
| */ | ||
| function _toUint256(bool value) private pure returns (uint256 result) { |
There was a problem hiding this comment.
I still think we should keep the original name. When reading the calling code, you have to double take to make sure you're converting a bool to int
cygaar
reviewed
Jun 14, 2022
| } | ||
| if (approvalCheck) | ||
| if (!_isOwnerOrApproved(approvedAddress, from, _msgSenderERC721A())) | ||
| if (!isApprovedForAll(from, _msgSenderERC721A())) revert TransferCallerNotOwnerNorApproved(); |
There was a problem hiding this comment.
Can you combine this with the if-statement on 706? The formatting looks weird right now.
There was a problem hiding this comment.
This is intentional for performance.
There was a problem hiding this comment.
Can you add a comment here then? I know people are going to ask about this otherwise.
cygaar
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make using assembly more worth it imo.
The happy case may cost at most 3 gas more, but when there are approvals, we can save tens to hundreds of gas.
https://www.diffchecker.com/jZfRzVAz
@cygaar
Changes:
_transfer, intotransferFromto save around 30 gas.Renamed the private function,_boolToUint256, to_toUint256for conciseness. Line lengths are getting a bit long, and it is obvious from the context that the input is a bool.approvedAddressand it’s corresponding slot. The slot allows us to delete it later without recomputing the keccak256, be it via assembly or implicitly with plain Solidity._deleteApprovedAddress, is replaced with the above functions.