Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_boolToUint256
with the shifting into a_nextInitializedFlag
function.The line is too long and triggers my OCD,
and we can put the duplicated bitwise shifting stuff into the function.
_currentIndex = startTokenId + quantity;
to_currentIndex = end;
. Saves 1 gas.Comments:
After some consideration, I've decided not to use assembly for the mint loop for now.
I know it saves 30 gas per iteration (0.4% savings for a batch of 10),
but it is hard to make it look pretty with all the magic numbers.
Anyway, ETH is cheap now.