Support resizing via control codes. #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-morgan Looks like this isn't supported anymore. What about moving the PR to https://github.com/sourcelair/xterm.js? Is it even necessary anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don’t quite need this for my ttyrec player (when termrec produces files, the resizing code is in a predictable place, so I can pick it up easily), but I’d prefer to have it implemented in term.js itself as it much more conveniently allows for resizing the terminal after the start, something which can happen. Still, I won’t quibble if you reject it—I’ll have an appropriate citation as to why I use a different approach.