-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(k9s) Include new Amd 64 version #2170
(k9s) Include new Amd 64 version #2170
Conversation
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
✅ Package verification completed without issues. PR is now pending human review |
✅ Package verification completed without issues. PR is now pending human review |
Let me know if you are missing anything else! |
The names of the archives for k9s has changed to use amd64 in the file name instead of x86-64. This commit makes the necessary changes to reflect that file name change.
89a3d05
to
85c79d5
Compare
✅ Package verification completed without issues. PR is now pending human review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have taken the liberty to reword the commits you made and squashed them.
In the future, please try to word the commits you make appropriately and always use the package name inside parentheses as a prefix in both the PR title and the commit summary.
I am saying this now as we may start rejecting commits not worded correctly in the future.
In PR derailed/k9s#1910 the x86_64 in the release was changed to amd64
so that :
k9s_Windows_x86_64.tar.gz
changed into
k9s_Windows_amd64.tar.gz
Description
This will check for both and select the correct version
This will also close #1999
Motivation and Context
It is really annoying that it is still not up to date to the latest version available
Types of changes
Checklist: