Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(k9s) Include new Amd 64 version #2170

Merged

Conversation

danielkoek
Copy link
Contributor

@danielkoek danielkoek commented Mar 10, 2023

In PR derailed/k9s#1910 the x86_64 in the release was changed to amd64
so that :
k9s_Windows_x86_64.tar.gz
changed into
k9s_Windows_amd64.tar.gz

Description

This will check for both and select the correct version

This will also close #1999

Motivation and Context

It is really annoying that it is still not up to date to the latest version available

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@danielkoek danielkoek mentioned this pull request Mar 10, 2023
4 tasks
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

pauby
pauby previously requested changes Mar 10, 2023
automatic/k9s/update.ps1 Outdated Show resolved Hide resolved
automatic/k9s/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
automatic/k9s/tools/chocolateyinstall.ps1 Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@danielkoek
Copy link
Contributor Author

Let me know if you are missing anything else!

@danielkoek danielkoek requested a review from pauby March 20, 2023 14:44
@AdmiringWorm AdmiringWorm changed the title K9s Include new Amd 64 version (k9s) Include new Amd 64 version Mar 24, 2023
The names of the archives for k9s has changed
to use amd64 in the file name instead of x86-64.

This commit makes the necessary changes to reflect
that file name change.
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have taken the liberty to reword the commits you made and squashed them.

In the future, please try to word the commits you make appropriately and always use the package name inside parentheses as a prefix in both the PR title and the commit summary.

I am saying this now as we may start rejecting commits not worded correctly in the future.

@AdmiringWorm AdmiringWorm dismissed pauby’s stale review March 24, 2023 10:23

So we can merge the changes

@AdmiringWorm AdmiringWorm merged commit e356a4d into chocolatey-community:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(k9s) outdated
4 participants