Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package version normalization is not being applied everywhere #1005

Closed
4 tasks done
AdmiringWorm opened this issue Jun 2, 2023 · 1 comment · Fixed by #1006
Closed
4 tasks done

Package version normalization is not being applied everywhere #1005

AdmiringWorm opened this issue Jun 2, 2023 · 1 comment · Fixed by #1006
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Milestone
2.1.0

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my problem.
  • I have verified this is not an issue for a specific package.
  • I have verified this issue is not security related.

What You Are Seeing?

There are places we have missed in the release of v2.0.0 that we aren't normalizing the version numbers when displaying or using these.
As Chocolatey CLI normalizes the version numbers, we should do the same in CHocolatey GUI.

What is Expected?

That every place that displays, or uses version numbers as a string forces the use of normalized version numbers even if the upstream package wasn't created this way.

How Did You Get This To Happen?

N/A

System Details

  • Operating System: Windows 10
  • Windows PowerShell version: Windows PowerShell 5.1
  • Chocolatey GUI Version: 2.0.0
  • Chocolatey Licensed Extension version: N/A
  • Chocolatey License type: N/A
  • Terminal/Emulator: Tabby and Windows PowerShell

Installed Packages

7zip 22.1.0
7zip.install 22.1.0
azcopy10 10.18.1
baretail 3.50.0.20120226
brave 1.51.118
choco-av-security 0.2.0
choco-falcon-security 6.49.16303
chocolatey 2.0.0
chocolatey.extension 6.0.0
chocolatey-agent 2.0.0
chocolatey-compatibility.extension 1.0.0
chocolatey-core.extension 1.4.0
chocolatey-dotnetfx.extension 1.0.1
chocolateygui 2.0.0
chocolateygui.extension 2.0.0
chocolatey-license-kim 0.1.0
chocolatey-visualstudio.extension 1.10.2
chocolatey-windowsupdate.extension 1.0.5
cleanup-desktop-shortcuts.hook 0.1.0-alpha-20221103
DotNet3.5 3.5.20160716
DotNet4.5.2 4.5.2.20140902
DotNet4.6.1 4.6.1055.20170308
dotnet4.7 4.7.2053.20190226
dotnet-6.0-aspnetruntime 6.0.16
dotnet-6.0-desktopruntime 6.0.16
dotnet-6.0-runtime 6.0.16
dotnet-6.0-sdk 6.0.408
dotnet-6.0-sdk-4xx 6.0.408
dotnet-7.0-sdk 7.0.302
dotnet-7.0-sdk-1xx 7.0.105
dotnet-7.0-sdk-2xx 7.0.203
dotnet-7.0-sdk-3xx 7.0.302
dotnetcore-3.1-sdk 3.1.426
dotnetcore-3.1-sdk-4xx 3.1.426
dotnetcore-sdk 3.1.426
dotnetfx 4.8.0.20220524
dotnet-sdk 7.0.302
dotPeek 2023.1.1
fiddler 5.0.20211.51073
gh 2.29.0
git 2.40.1
git.install 2.40.1
gitextensions 4.1.0
glab 1.30.0
glab.portable 1.30.0
gpg4win 4.1.0
grammarly-for-windows 1.0.33.501
gsudo 2.0.9
ilspy 8.0.0
KB2533623 2.0.0
KB2919355 1.0.20160915
KB2919442 1.0.20160915
KB2999226 1.0.20181019
KB3033929 1.0.5
KB3035131 1.0.3
KB3063858 1.0.0
KB3118401 1.0.5
keybase 6.0.1
linqpad 7.6.6
linqpad7 7.6.6
linqpad7.install 7.6.6
lockhunter 3.4.3.20220526
netfx-4.7.2 4.7.2
netfx-4.7.2-devpack 4.7.2.20210903
netfx-4.8 4.8.0.20220524
netfx-4.8-devpack 4.8.0.20190930
nodejs-lts 18.16.0
notepadplusplus 8.5.3
notepadplusplus.install 8.5.3
nuget.commandline 6.6.0
NugetPackageExplorer 6.0.64
oh-my-posh 16.9.0
papercut 6.0.0
pcloud-drive 4.1.1
powershell-core 7.3.4
pwsh 7.3.4
resharper-platform 231.0.20230511.204056
sql-server-express 2022.16.0.1000
sql-server-management-studio 19.0.20209
sysinternals 2023.5.24
tabby 1.0.197
transifex-cli 1.6.7
vcredist140 14.36.32532
vcredist2015 14.0.24215.20170201
visualstudio2022professional 117.5.5
visualstudio2022-workload-manageddesktop 1.0.1
visualstudio2022-workload-visualstudioextension 1.0.0
visualstudio-installer 2.0.3
vscode 1.78.2
vscode.install 1.78.2
wixtoolset 3.11.2
yarn 1.22.19

Output Log

N/A

Additional Context

This is issue is created in combination with CLI issue: chocolatey/choco#3174
@AdmiringWorm AdmiringWorm added Bug Issues where something has happened which was not expected or intended 2 - Working A user or team member has started working on the issue labels Jun 2, 2023
@AdmiringWorm AdmiringWorm added this to the vNext milestone Jun 2, 2023
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 2, 2023
@AdmiringWorm
(chocolatey#1005) Normalize version numbers
d582f87 
This updates all displaying of version numbers
and usages internally to ensure that the version
numbers are normalized.

This is the equivalent of changes made in Chocolatey CLI.
@AdmiringWorm AdmiringWorm mentioned this issue Jun 2, 2023
Merged
10 tasks
@gep13 gep13 modified the milestones: vNext, 2.0.1 Jun 5, 2023
gep13 pushed a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 6, 2023
@AdmiringWorm @gep13
(chocolatey#1005) Normalize version numbers
834479d 
This updates all displaying of version numbers
and usages internally to ensure that the version
numbers are normalized.

This is the equivalent of changes made in Chocolatey CLI.
gep13 added a commit that referenced this issue Jun 6, 2023
@gep13
Merge pull request #1006 from AdmiringWorm/version-norm
b692313 
(#1005) Normalize version numbers
@gep13 gep13 changed the title Version normalization is not being applied everywhere Package version normalization is not being applied everywhere Jun 8, 2023
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 2 - Working A user or team member has started working on the issue labels Jun 9, 2023
gep13 added a commit that referenced this issue Jun 29, 2023
@gep13
Merge branch 'release/2.1.0'
7cc2949 
* release/2.1.0:
  (maint) Update to latest version of chocolatey.lib
  (maint) Update GRM configuration file
  (maint) Remove version bump in nuspec file
  (build) Use latest Chocolatey.Cake.Recipe package
  (maint) Switch to Http for variable names
  (#1014) Add advanced option to ignore cached items
  (#1014) Ignore cached files on forced outdated check
  (build) Make build files consistent with others
  (#993) (fix) Correct syntax in KTS file
  (#993) Add TC schedule trigger
  (maint) Fix StyleCop warnings
  (#980) Use assembly location when debugging
  (maint) Update to released alpha package
  (#1003) Handle null keys during source translation
  (#1005) Normalize version numbers
  (maint) Add banned api analyzer
  (maint) Remove usage of obsolete methods
  (maint) Update to latest Chocolatey.Lib package
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Jun 29, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

(#1005) Normalize version numbers AdmiringWorm/ChocolateyGUI
3 participants
@gep13 @AdmiringWorm @choco-bot