Add confirmation dialog for update all button

[gep13]

This operation can potentially take a long time, and we should confirm with the user as to whether they really want to do this right now.

[gep13]

Similar issues exist for other operations:

• Add confirmation dialog when performing an Uninstall/Reinstall operation from context menu #786
• Add confirmation dialog for update all button #828
• Add confirmation dialog when removing a source #827

[opusforlife2]

Or the ability to cancel the operation?

[gep13]

@opusforlife2 that work would be covered as part of a different issue, for example here:

#720

[opusforlife2]

@gep13 I know. That's my issue. :P

What I was suggesting is that this doesn't need to be implemented if the ability to cancel already exists.

[gep13]

I understand your point, and I was aware that it was your issue. The main reason that I created this issue, with the links to the other ones, is for consistency. When starting an operation that is potentially destructive, or which may take a long time to complete, a modal window asking whether the user is sure makes sense. We already have some modals for the operations that can be performed on the setting screen, so adding them into each of the listed issues, brings consistency to the application.

Then later, for the longer running processes we should introduce the ability to cancel the operation. This has to be done in such a way that it doesn't "break" anything, as we wouldn't want an installation/upgrade to end abruptly, and leave the package in a broken state. That is why it is a different scope of work.

[opusforlife2]

Ah. Got it.

[gep13]

This has been implemented, and looks like the following:

[opusforlife2]

Awesome! Thank you so much! :D

[gep13]

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

• GitHub Release
• Chocolatey Package

Your GitReleaseManager bot 📦🚀