Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chocolatey GUI incorrectly reverts to list view after making a change in settings screen #830

Closed
gep13 opened this issue Mar 18, 2021 · 4 comments
Closed

Chocolatey GUI incorrectly reverts to list view after making a change in settings screen #830

gep13 opened this issue Mar 18, 2021 · 4 comments
Assignees
@gep13
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.18.1

Comments

@gep13
Copy link
Member

gep13 commented Mar 18, 2021

Starting with Chocolatey GUI 0.18.0, the default is to show both local and remote sources using the Tile View. This works on application startup, and persists across closing and opening the application, however, if you modify another settings, i.e. toggling a feature on or off, when you return to the main screen, the Tile View will no longer be being used, and instead, it will have reverted to the List View.

Steps to reproduce

  1. Open Chocolatey GUI
  2. Verify that Tile View is shown by default
  3. Click on the settings link
  4. Toggle on (or off) the Show Console Output feature
  5. Click the back button to return to main screen
  6. See that the List View is now shown, rather than the default Tile View
@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Mar 18, 2021
@gep13 gep13 added this to the 0.18.1 milestone Mar 18, 2021
@gep13 gep13 self-assigned this Mar 18, 2021
@punker76
Copy link
Member

@gep13 I also noticed this yesterday :-(

@punker76
Copy link
Member

@gep13 This happens also if I change any of the other settings e.g. like the outdated package duration time.

@gep13
Copy link
Member Author

gep13 commented Mar 18, 2021

@punker76 yip, I messed up 😢 I know where the issue is, and I have a local fix for it. Yip, this isn't only on the Show Console Output feature, this was just an example.

gep13 added a commit that referenced this issue Mar 19, 2021
@gep13
(#830) Send correct settings to event
2c6f188 
When invoking the SettingsChanged event, we need to make sure to send
the complete EffectiveAppConfiguration rather than the ones that are
currently being edited. That way, the UI can correctly update (where
required) with the actual settings that are currently in play.
@gep13 gep13 closed this as completed Mar 19, 2021
@AdmiringWorm AdmiringWorm mentioned this issue Mar 25, 2021
Closed
@gep13 gep13 changed the title Chocolatey GUI reverts to List View after making a change in settings Chocolatey GUI incorrectly reverts to list view after making a change in settings screen Mar 29, 2021
gep13 added a commit that referenced this issue Mar 29, 2021
@gep13
Merge branch 'hotfix/0.18.1' into master
f2615ab 
* hotfix/0.18.1:
  (#831) Add missing backtick in nuspec
  (#832) Ensure to correctly dispose of database
  (#829) Ensure application starts without global db
  (#830) Send correct settings to event
gep13 added a commit that referenced this issue Mar 29, 2021
@gep13
(#830) Send correct settings to event
878db54 
When invoking the SettingsChanged event, we need to make sure to send
the complete EffectiveAppConfiguration rather than the ones that are
currently being edited. That way, the UI can correctly update (where
required) with the actual settings that are currently in play.
gep13 added a commit that referenced this issue Mar 29, 2021
@gep13
Merge branch 'hotfix/0.18.1' into develop
3e89b47 
* hotfix/0.18.1:
  (#831) Add missing backtick in nuspec
  (#832) Ensure to correctly dispose of database
  (#829) Ensure application starts without global db
  (#830) Send correct settings to event
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.1 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.18.1
Development

No branches or pull requests
3 participants
@punker76 @gep13 @choco-bot