Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running Chocolatey GUI, ensure installed Chocolatey assembly is used, rather than locally referenced assembly #857

Closed
AdmiringWorm opened this issue Jun 1, 2021 · 1 comment · Fixed by #858
Closed

When running Chocolatey GUI, ensure installed Chocolatey assembly is used, rather than locally referenced assembly #857

AdmiringWorm opened this issue Jun 1, 2021 · 1 comment · Fixed by #858
Assignees
@AdmiringWorm
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.18.2

Comments

@AdmiringWorm
Copy link
Member

When running Chocolatey GUI and Chocolatey GUI CLI we should load the main assembly (choco.exe) instead of running the statically referenced DLL file we have compiled against.

This will allow changes to Chocolatey extensions to make use of new functionality in Chocolatey, or include any bug fixes in Chocolatey without having to publish a new version of Chocolatey GUI.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 1, 2021
@AdmiringWorm
(chocolatey#857) Load Chocolatey executable assembly
8cd59ad 
This commit makes changes to the assembly loader to
load the installed Chocolatey executable as an
assembly instead of the statically referenced
DLL file
@AdmiringWorm AdmiringWorm mentioned this issue Jun 1, 2021
Merged
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 1, 2021
@AdmiringWorm
(chocolatey#857) Load Chocolatey executable assembly
4c6a077 
This commit makes changes to the assembly loader to
load the installed Chocolatey executable as an
assembly instead of the statically referenced
DLL file

These changes are necessary to ensure that there will
be minimal incompatibilities between running Chocolatey CLI
and Chocolatey GUI for both FOSS and Licensed users.
AdmiringWorm added a commit to AdmiringWorm/ChocolateyGUI that referenced this issue Jun 2, 2021
@AdmiringWorm
(chocolatey#857) Load Chocolatey executable assembly
232b47a 
This commit makes changes to the assembly loader to
load the installed Chocolatey executable as an
assembly instead of the statically referenced
DLL file

These changes are necessary to ensure that there will
be minimal incompatibilities between running Chocolatey CLI
and Chocolatey GUI for both FOSS and Licensed users.
@AdmiringWorm AdmiringWorm added this to the 0.18.2 milestone Jun 2, 2021
@AdmiringWorm AdmiringWorm added the Bug Issues where something has happened which was not expected or intended label Jun 2, 2021
@AdmiringWorm AdmiringWorm self-assigned this Jun 2, 2021
gep13 added a commit that referenced this issue Jun 3, 2021
@gep13
Merge pull request #858 from AdmiringWorm/use-choco-exec
f0587b1 
(#857) Load Chocolatey executable assembly
@gep13 gep13 closed this as completed Jun 3, 2021
@gep13 gep13 changed the title Load Chocolatey main assembly during runtime When running Chocolatey GUI, ensure installed Chocolatey assembly is used, rather than locally referenced assembly Sep 2, 2021
gep13 added a commit that referenced this issue Sep 2, 2021
@gep13
Merge branch 'hotfix/0.18.2'
3dff7ef 
* hotfix/0.18.2:
  (maint) Update to use correct URL
  (#880) Use PNG for Nuspec IconUrl
  (#857) Load Chocolatey executable assembly
gep13 added a commit that referenced this issue Sep 2, 2021
@gep13
Merge branch 'hotfix/0.18.2' into develop
0c626b4 
* hotfix/0.18.2:
  (maint) Update to use correct URL
  (#880) Use PNG for Nuspec IconUrl
  (#857) Load Chocolatey executable assembly
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.2 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.18.2
Development

Successfully merging a pull request may close this issue.

(#857) Load Chocolatey executable assembly AdmiringWorm/ChocolateyGUI
3 participants
@gep13 @AdmiringWorm @choco-bot