(#770) Provide ability to see persisted arguments for installed package #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
force-pushed
the
770-Provide-ability-to-see-persisted-arguments-for-installed-package
branch
from
73623ed
to
cc810ef
Compare
|
@gep13 this PR have been updated with the latest changes, and updated to use the dynamic languages for the resource strings. |
This commit replaces the values in sensitive arguments to instead show the translatable string `[REDACTED ARGUMENT]` to ensure that sensitive arguments are not displayed to the user. This relies on the ArgumentUtility helper to detect whether the sensitive argument should be shown or not.
This commit updates the dialog for showing package arguments to have a notice that no arguments was found for the package in the same dialog as normal arguments would show up with.
This commit updates the package view to hide the button for displaying package arguments when it is not displayed.
AdmiringWorm
force-pushed
the
770-Provide-ability-to-see-persisted-arguments-for-installed-package
branch
from
cc810ef
to
1413254
Compare
|
@AdmiringWorm this all looks good to me, thanks for pulling all this together! |
AdmiringWorm
deleted the
770-Provide-ability-to-see-persisted-arguments-for-installed-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This pull request updates the code that was added previously for displaying package arguments with code to hide sensitive arguments, only do a log if the arguments file can not be found, display a message about no arguments could not be found if nothing is returned and to hide the button for viewing package arguments when the package is not installed.
Motivation and Context
The sensitive arguments are changed to not be displayed, as we do not want to dispay these arguments to the users in the possibility that they are not the same user as the one that installed the package.
Changing to logging of the file not found was to prevent duplicated dialogs to be shown, but still give the information about no arguments being available.
Additionally, there is no reason to be able to view package arguments for packages that are not installed.
Testing
Change Types Made
Related Issue
Fixes #770
Change Checklist