Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option/feature to stop installation when a package fails #1151

Closed
ferventcoder opened this issue Jan 26, 2017 · 2 comments
Closed

Option/feature to stop installation when a package fails #1151

ferventcoder opened this issue Jan 26, 2017 · 2 comments

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Jan 26, 2017

There should be an option to allow Chocolatey to stop the chain of installs if one of the items fails. It should be an opt-in option / feature as most folks would be using Chocolatey where dependencies are app to app (most of the time).

Reference

Originally we switched from doing this automatically way back in 0.9.8.25. However in discussion @rismoney asked for a full stop if there was a failure in the chain - chocolatey-archive/chocolatey#192 (comment).

Features / Options

The feature is stopOnFirstPackageFailure, but it is not recommended as it will also be applied to choco upgrade all and if a package fails, it won't continue with the upgrade process of other packages.

Instead, add --stop-on-first-failure to your install/upgrade/uninstall options.

@rismoney
Copy link
Contributor

booya! fail early FTW!

ferventcoder added a commit that referenced this issue Mar 19, 2017
Add option/feature to stop on first package failure. Although it is
normally recommended to let the process continue when one package
fails, sometimes it is best to stop further action from occurring.
@ferventcoder
Copy link
Member Author

Completed for 0.10.4.

ferventcoder added a commit that referenced this issue Mar 19, 2017
* stable:
  (GH-1098) Get-FtpFile - change int to long / improve error handling
  (docs) update generated docs
  (GH-1187) Get-ChocolateyUnzip - support both archs
  (GH-1039) Remove quotes before testing path
  (GH-686) Upgrade Scenarios for Prereleases
  (GH-686) Upgrade Prereleases
  (GH-1151) Option - Stop on first package failure
  (GH-902) Fix: User changed to SYSTEM during env update
@ferventcoder ferventcoder changed the title Option/feature to stop installation when a dependency fails Option/feature to stop installation when a package fails Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants