Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quotes in process passed to Start-ChocolateyProcessAsAdmin / CommandExecutor #1167

Closed
ferventcoder opened this issue Feb 20, 2017 · 0 comments
Closed

Remove quotes in process passed to Start-ChocolateyProcessAsAdmin / CommandExecutor #1167

ferventcoder opened this issue Feb 20, 2017 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Customer Improvement
Milestone
0.10.4

Comments

@ferventcoder
Copy link
Member

Sometimes when passing things through from one query to Start-ChocolateyProcessAsAdmin, the quotes will still be there when running a process. This makes the execution fail on something it doesn't need to.
@ferventcoder ferventcoder added this to the 0.10.4 milestone Feb 20, 2017
@ferventcoder ferventcoder self-assigned this Feb 20, 2017
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 20, 2017
@ferventcoder
(chocolateyGH-1167) Remove quotes before Process call
dd3dede 
In CommandExecutor and Start-ChocolateyProcessAsAdmin, sometimes those
can get called with an executable to run that is surrounded by quotes.
Always remove those quotes so that the process will not fail with
messages similar to:

`Exception calling "Start" with "0" argument(s): "The parameter is
incorrect"`

Without this change, a user needs to ensure that the quotes are
stripped out manually, which can sometimes be hard to determine that is
what needs to be done based on the cryptic error message.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 27, 2017
@ferventcoder
Merge branch 'stable'
96175f7 
* stable:
  (chocolateyGH-1134) Show download progress for packages
  (chocolateyGH-1134) Specify Package Downloader
  (chocolateyGH-1165) fix - bypass on local set
  (chocolateyGH-605) Use Proxy From Environment Vars
  (chocolateyGH-1167) Remove quotes before Process call
  (chocolateyGH-1166) Fix: Multiple Licensed Sources
  (chocolateyGH-1165) Bypass Proxy on Local
  (chocolateyGH-1165) Config - Proxy Bypass List
  (chocolateyGH-262) Sources Explicitly Bypass Proxy
  (chocolateyGH-262) NuGet.Core - explicit source proxy ignore
@ferventcoder ferventcoder mentioned this issue Mar 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Customer Improvement
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@ferventcoder @gep13