Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting issues on --noop command logging #202

Closed
ferventcoder opened this issue Mar 24, 2015 · 0 comments
Closed

Formatting issues on --noop command logging #202

ferventcoder opened this issue Mar 24, 2015 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.9.3

Comments

@ferventcoder
Copy link
Member

https://groups.google.com/d/msgid/chocolatey/5ea6bfba-eda6-4bfd-b20d-9b44415e1c1a%40googlegroups.com?utm_medium=email&utm_source=footer

"I've noticed since updating to 0.9.9.2 I've noticed the --noop or --whatif option. Great, I thought. I was curious whether and install would get the 32bit or 64bit version AND where it would write to. So I try cinst conemu --noop and instead of getting readable output I see pages of source code ending with "System.FormatException: Input string was not in a correct format." Same for other programs (vim, atom). But some, like autoHotkey.portable produces NO errors, but tells me what files will be downloaded."
@ferventcoder ferventcoder added this to the 0.9.9.3 milestone Mar 24, 2015
@ferventcoder ferventcoder mentioned this issue Mar 29, 2015
Closed
@ferventcoder ferventcoder self-assigned this Mar 29, 2015
ferventcoder added a commit that referenced this issue Mar 29, 2015
@ferventcoder
(GH-202) Fix formatting on Noop logging
b227b35
ferventcoder added a commit that referenced this issue Mar 29, 2015
@ferventcoder
(GH-202)(log) Enhance formatting escaping
8f5ee90 
- Escape curly braces only when there is a single curly brace - allows
idempotency
- Use Format calls on regular logging calls so that format escaped items
are properly logged
ferventcoder added a commit to ferventcoder/choco that referenced this issue Mar 29, 2015
@ferventcoder
Merge branch 'stable'
ce90c21 
* stable:
  (version) 0.9.9.3
  (doc) update nuspec / changelog for release
  (chocolateyGH-211) Use full path to msiexec
  (chocolateyGH-197) Uninstaller check for registry existence
  (chocolateyGH-167) Get-ChocolateyWebFile create directory
  (chocolateyGH-207) Set up variables for powershell scripts
  (chocolateyGH-202)(log) Enhance formatting escaping
  (chocolateyGH-202) Fix formatting on Noop logging
  (chocolateyGH-208) Do not escape curly braces in scripts
  (chocolateyGH-168) Retry .NET Fx if first install fails
  (chocolateyGH-168) .NET Framework 4.0 install egg/chicken
  (chocolateyGH-207) Some pkgs incorrectly use arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.9.3
Development

No branches or pull requests
2 participants
@ferventcoder @gep13