Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back validation messages after upgrade to NuGet v3+ #3000

Closed
2 tasks done
AdmiringWorm opened this issue Jan 26, 2023 · 1 comment · Fixed by #3001 or #3037
Closed
2 tasks done

Add back validation messages after upgrade to NuGet v3+ #3000

AdmiringWorm opened this issue Jan 26, 2023 · 1 comment · Fixed by #3001 or #3037
Assignees
@AdmiringWorm
Labels
5 - Released NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. Task
Milestone
2.0.0

Comments

@AdmiringWorm
Copy link
Member

AdmiringWorm commented Jan 26, 2023 •
edited by gep13
Loading

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

When we uplifted the project to make use of the latest available version of NuGet Client libraries we lost quite a few validation messages that is present in Chocolatey CLI v1.x.

Describe The Solution. Why is it needed?

We should add the validation messages lost in the uplift, especially error-related validation messages.
We should additionally look at updating these messages to be more helpful to the user simultaneously.

Additional Context

No response

Related Issues
@AdmiringWorm AdmiringWorm added this to the 2.0.0 milestone Jan 26, 2023
@AdmiringWorm AdmiringWorm self-assigned this Jan 26, 2023
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Add new rule service to handle custom rules
5d009df 
This commit adds a new rule service together with some base types
that will be used by the service itself, and any implementing
rule.
This service takes a path to a `nupkg` file or to a `nuspec` file
and passes along the appropriate values necessary
to validate the metadata that is being used for the
package.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Move unsupported element rules to rule classes
815c3e6 
This commit moves the existing rules that was added previously for
unsupported metadata to their own classes that hooks
into the rule service to make the validation.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Add back old validation messages for custom rules
08cc2f0 
This commit adds back the validation messages that was
already being used in v1 but is missing in the uplifted
v2 version.
Additionally, this commit also updates the validation
messages to be more user friendly.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Update e2e tests with new rule validations
e9ef35a
@AdmiringWorm AdmiringWorm mentioned this issue Jan 26, 2023
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Move unsupported element rules to rule classes
90f2d0a 
This commit moves the existing rules that was added previously for
unsupported metadata to their own classes that hooks
into the rule service to make the validation.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Add back old validation messages for custom rules
7f3dc2e 
This commit adds back the validation messages that was
already being used in v1 but is missing in the uplifted
v2 version.
Additionally, this commit also updates the validation
messages to be more user friendly.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 26, 2023
@AdmiringWorm
(chocolatey#3000) Update e2e tests with new rule validations
b2e8443
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 27, 2023
@AdmiringWorm
(chocolatey#3000) Add new rule service to handle custom rules
fbe4c0f 
This commit adds a new rule service together with some base types
that will be used by the service itself, and any implementing
rule.
This service takes a path to a `nupkg` file or to a `nuspec` file
and passes along the appropriate values necessary
to validate the metadata that is being used for the
package.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 27, 2023
@AdmiringWorm
(chocolatey#3000) Move unsupported element rules to rule classes
e9e180e 
This commit moves the existing rules that was added previously for
unsupported metadata to their own classes that hooks
into the rule service to make the validation.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 27, 2023
@AdmiringWorm
(chocolatey#3000) Add back old validation messages for custom rules
e66c3da 
This commit adds back the validation messages that was
already being used in v1 but is missing in the uplifted
v2 version.
Additionally, this commit also updates the validation
messages to be more user friendly.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Jan 27, 2023
@AdmiringWorm
(chocolatey#3000) Update e2e tests with new rule validations
c21b121
gep13 added a commit that referenced this issue Jan 27, 2023
@gep13
Merge pull request #3001 from AdmiringWorm/readd-pack-validations
c6e30b7 
(#3000) Create new rule service and read old validation messages
@gep13 gep13 added 4 - Done and removed 3 - Review labels Jan 27, 2023
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 14, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
16c579a 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 20, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
140155f 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
@AdmiringWorm AdmiringWorm mentioned this issue Feb 20, 2023
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 20, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
92ff973 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 20, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
603c0c6 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 20, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
7de462f 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 21, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
c707ca4 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Feb 21, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
da8e890 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Mar 1, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
91f7bfc 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
@gep13 gep13 linked a pull request Mar 1, 2023 that will close this issue
(#3000) Add additional information in validation messages #3037
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/choco that referenced this issue Mar 1, 2023
@AdmiringWorm
(chocolatey#3000) Update rules to include id and help
8e30abd 
This commit updates the rule results and its
implemented rules to include an identifier
and optionally a url to where more information
can be found about the rule.

This is done to make it easier in the future
to add/update additional functionality in
extensions.
gep13 added a commit that referenced this issue Mar 2, 2023
@gep13
Merge pull request #3037 from AdmiringWorm/rules-enhancement
18c0d6e 
(#3000) Add additional information in validation messages
@gep13 gep13 added the NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. label May 18, 2023
@corbob corbob added Task and removed Improvement labels May 19, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. Task
Projects
None yet
Milestone
2.0.0
4 participants
@gep13 @AdmiringWorm @choco-bot @corbob