Remove randomness by default of BBox strategies #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 936da04.
jgFages
reviewed
Oct 23, 2023
| public DomOverWDegRef(V[] variables, long seed) { | ||
| super(variables, seed); | ||
| public DomOverWDegRef(V[] variables) { | ||
| this(variables, (v1, v2) -> 0, 32); |
There was a problem hiding this comment.
J'aurais mis la lambda dans une constante pour que ce soit plus lisible / réutilisé
public final static Comparator<V> NO_TIE_BREAK = (v1, v2) -> 0;
Ou plutôt LEX_TIE_BREAK si par conséquence on a un résultat ordonné en lexico (j'ai eu un doute).
There was a problem hiding this comment.
Je vois que le 32 est utilisé à différents endroits, je l'aurais aussi mis en variable static (pas final) DEFAULT_FLUSH_RATE
Pour le suivi des modifications, si demain on passe à 50, c'est plus simple d'associer cela à un nom...
There was a problem hiding this comment.
Harmoniser avec SearchParams
jgFages
reviewed
Oct 23, 2023
| public DomOverWDeg(V[] variables, long seed) { | ||
| this(variables, seed, Integer.MAX_VALUE); | ||
| public DomOverWDeg(V[] variables) { | ||
| this(variables, (v1, v2)->0, 32); |
jgFages
reviewed
Oct 23, 2023
| switch (tiebreaker) { | ||
| default: | ||
| case LEX: | ||
| tie = (v1, v2) -> 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this as a fresh start of #1066.
I will add some graphs when I found enough time to run benchmarks.
So, the idea here is as much about the feature itself and about not losing it on my computer 😄
Reverts #1068