Disable Babel modules transform for dependencies #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Babel modules transform turns top level `this` into undefined. This causes issues with some libraries that expect `this` to refer to the global object (or at least expect it to exist). See #423 for an example. Because browserify looks for the package.json `main` key, which should not contain ES modules code, it should be safe to just disable the modules transform.
goto-bus-stop
force-pushed
the
fix/babelify-deps
branch
from
65f76e6 to
ead46a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a 🐛 bug fix
The Babel modules transform turns top level
thisinto undefined. Thiscauses issues with some libraries that expect
thisto refer to theglobal object (or at least expect it to exist). See #423 for an example.
Because browserify looks for the package.json
mainkey, which shouldnot contain ES modules code, it should be safe to just disable the
modules transform.
Checklist
Context
#423
And a different take on #422
Semver Changes
Patch