your-first-app work in progress

[timwis]

Just a start, let me know if you think it's on the right track

[yoshuawuyts]

This is amazing! 🎉

[timwis]

Okay folks, I've finished this tutorial - I'd love some feedback! You can view it in the Files tab above and add inline comments, and click the View button at the top of the file to see it rendered in markdown.

I imagine this could be the first choo app newcomers build, so starting with the right best practises, naming conventions, ideas, etc. are important here. I'm open to all kinds of feedback. Thanks!

[toddself]

We shouldn't use simple in here since it can potentially color someone's expectations of this works (they might not think what is happening is simple!). Can we change this to small?

[toddself]

The only thing is that does send call the callback you're passing in in the effect? From what I understood, you needed to invoke the function when your effect was complete?

I'm just about to dive into the 3.0 upgrade process for my code though so I haven't played with this yet

[yoshuawuyts]

. . . used to confuse me a lot before I knew how to JS; like: is it real syntax? A comment would perhaps be more clear

[yoshuawuyts]

Really liking this; great work hey ✨

One minor concern I have is overwhelming people with ES6 syntax; I think that even with the modest subset you've chosen for the examples here, it might be too much for people to feel comfortable with either if they're new to the language or are slowly inching back into it.

What I'd recommend doing is sticking to es2020 syntax and require('xtend') which both synergizes with choo's internals, is well documented and should allow people to create applications that work everywhere from the get-go (e.g. budo -- -t es2020). If anyone has knowledge or preferences beyond that; people are free to use whatever they want.

I recognize this is definitely a matter of taste though; but I feel it would be for the better.

[timwis]

Hey guys, great feedback all around, thank you. I've reduced the ES6 as you suggested, replaced "simple" with "small" and improved the explanation around unidirectional dataflow etc. Should be good to go then!

[timwis]

Going to merge, hope that's okay. Feel free to revert if not. Also, I removed the 2 dead links in the readme since we have #10 in place.

The only thing is that does send call the callback you're passing in in the effect? From what I understood, you needed to invoke the function when your effect was complete?

@yoshuawuyts, can you answer that when you get a sec? I was working off of choo's http example

[yoshuawuyts]

Remote now, but yes, send() must always be called when done - otherwise a caller up the stack (e.g. Another effect) will not know when it's done

[timwis]

What if your effect executes more than one reducer?

[yoshuawuyts]

Like this ✨

function myEffect (data, state, send, done) {
  send('some:reducer', () => {
    send('some:otherReducer', done)
  })
}

Or using run-series:

const series = require('run-series')

function myEffect (data, state, send, done) {
  const reducers = [
    (done) => send('some:reducer', done),
    (done) => send('some:otherReducer', done)
  ]
  series(reducers, done)
}

And there's definitely ways of doing it with pull-stream, but I'm a noob so can't write it off the top off my head hah. Anyway; hope this answers your question 😁

edit:
Using pull-stream, I think:

const pull = require('pull')

function myEffect (data, state, send, done) {
  const source = [
    (done) => send('some:reducer', done),
    (done) => send('some:otherReducer', done)
  ]
  pull(source, pull.asyncMap(send), pull.drain(null, done))
}