This repository has been archived by the owner on Feb 7, 2020. It is now read-only.
(#16) Validate before caching #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, I think this is quite a significant bug so we should add tests to specifically ensure this does not happen again in future. Once added please squash and change first line to |
* If you change the allow list, a cached cert will be allowed for non-privileged actions. This is not intuitive. * Make tests pass ``` filesec/file_security.go:404: Entry.Errorf format %s arg s.caPath is a func value, not called ``` * Allow list tests to ensure this doesn't happen again
vjanelle
force-pushed
the
validate_before_caching
branch
from
94b045a to
274360e
Compare
|
@ripienaar done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you change the allow list, a cached cert will be allowed for non-privileged actions. This is not intuitive.
Fixed a typo, and making tests pass locally.
Fixes #16