Skip to content
This repository has been archived by the owner on Feb 7, 2020. It is now read-only.

(#18) Add configuration flag to always overwrite the cache #20

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

vjanelle
Copy link
Contributor

  • Add configuration flag to filesec/puppetsec to tell the provider to
    always overwrite the local cache of a certificate with the one one
    that's been presented (defaults to false for existing environments)
  • Implement tests around configuration flag
  • Update test certificates to replicate an updated certificate being
    seen later

@vjanelle
Copy link
Contributor Author

vjanelle commented Nov 14, 2018

More than likely need choria-io/go-choria#479 to be merged.

Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, looks pretty good mostly.

Lets get the choria one in and then we'll udpate here to point to the new dependency

filesec/file_security.go Outdated Show resolved Hide resolved
filesec/file_security_test.go Outdated Show resolved Hide resolved
filesec/file_security_test.go Show resolved Hide resolved
filesec/file_security.go Outdated Show resolved Hide resolved
* Add configuration flag to filesec/puppetsec to tell the provider to
always overwrite the local cache of a certificate with the one one
that's been presented (defaults to false for existing environments)
* Implement tests around configuration flag
* Update test certificates to replicate an updated certificate being
seen later
@ripienaar ripienaar merged commit bdad0bf into choria-legacy:master Nov 15, 2018
@ripienaar
Copy link
Contributor

nice one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants