Skip to content

Commit

Permalink
Merge pull request #2 from chornthorn/fix/improve-error-handling
Browse files Browse the repository at this point in the history
refactor: improve error handling and validation
  • Loading branch information
chornthorn authored Nov 14, 2024
2 parents aef3728 + 14b83c3 commit 013303d
Show file tree
Hide file tree
Showing 2 changed files with 242 additions and 182 deletions.
18 changes: 15 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,27 @@
# Changelog

## [1.1.0] - 2024-11-13
## [1.1.1] - 2024-11-14

### Changed
- Changed TOTP setup endpoint from `GET` to `POST` method for `/realms/{realm}/khode-two-factor-auth/totp/setup/{user_id}` to follow better security practices
- Updated documentation to reflect the HTTP method change for TOTP setup endpoint
- Improved error handling across all endpoints
- Added comprehensive validation checks for user IDs and TOTP codes
- Introduced helper methods for better code organization and reusability
- Enhanced logging for error scenarios

### Fixed
- Improved error messages for better clarity
- Better handling of edge cases in TOTP operations

## [1.1.0] - 2024-11-13

### Added
- New endpoint `/realms/{realm}/khode-two-factor-auth/totp/is-configured/{user_id}` to check if TOTP is already configured for a user
- Added documentation for the new TOTP configuration check endpoint

### Changed
- Changed TOTP setup endpoint from `GET` to `POST` method for `/realms/{realm}/khode-two-factor-auth/totp/setup/{user_id}` to follow better security practices
- Updated documentation to reflect the HTTP method change for TOTP setup endpoint

### Security
- Improved security by changing TOTP setup to use POST instead of GET to prevent secret exposure in URL/logs

Expand Down
Loading

0 comments on commit 013303d

Please sign in to comment.