list oldest-supported-numpy as a build dependency
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that downstream packages won't have binary incompatibilities (see CAST-genomics/haptools#138 and https://pypi.org/project/oldest-supported-numpy/)
so that we can be compatible with python 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @chrchang,
Our team uses
pgenliband noticed an intermittent issue when installing it withpip. We've found that a binary incompatibility can occur when the version ofnumpyused to buildpgenlibis newer than the version used when runningpgenlib. We think the solution is to list theoldest-supported-numpypackage as a build-time dependency instead ofnumpy.See the README for
oldest-supported-numpyand the numpy documentation for more information on why this is advisable.See CAST-genomics/haptools#138 for our example instance of a binary incompatibility and a more detailed explanation of our problem in plain terms.
Thank you for reviewing and considering this!