Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cut down in libs #1

Merged

Conversation

barbudor
Copy link

@barbudor barbudor commented Sep 9, 2023

Description:

Porposition to cut down the libs while being non-breaking for your customers
The 2 defines at the top of each header could be commented in your official product and need to be uncommented in Tasmota (or by any customer of yours wanting to shrink the code)

@chrfriese123
Copy link
Owner

The cut down looks good to me. Although I think it would also be good to remove the serial.print/debugENSxxx parts completely from the library code.

@chrfriese123 chrfriese123 merged commit 4ecbd20 into chrfriese123:development Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants