tolerate missing short_version in [visualstudioappcenter]

chris48s · Feb 5, 2024 · 6702717 · 6702717
1 parent dc5b6e8
commit 6702717
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/services/visual-studio-app-center/visual-studio-app-center-releases-version.service.js b/services/visual-studio-app-center/visual-studio-app-center-releases-version.service.js
@@ -8,7 +8,7 @@ import {
 
 const schema = Joi.object({
   version: Joi.string().required(),
-  short_version: Joi.string().required(),
+  short_version: Joi.string().required().allow(''),
 }).required()
 
 export default class VisualStudioAppCenterReleasesVersion extends BaseVisualStudioAppCenterService {
@@ -53,6 +53,9 @@ export default class VisualStudioAppCenterReleasesVersion extends BaseVisualStud
       token,
       schema,
     })
+    if (!shortVersion) {
+      return renderVersionBadge({ version })
+    }
     return renderVersionBadge({
       version: `${shortVersion} (${version})`,
     })

diff --git a/services/visual-studio-app-center/visual-studio-app-center-releases-version.tester.js b/services/visual-studio-app-center/visual-studio-app-center-releases-version.tester.js
@@ -29,6 +29,21 @@ t.create('Invalid user, invalid project, valid API token')
     message: 'project not found',
   })
 
+t.create('Missing Short Version')
+  .get('/nock/nock/nock.json')
+  .intercept(nock =>
+    nock('https://api.appcenter.ms/v0.1/apps/')
+      .get('/nock/nock/releases/latest')
+      .reply(200, {
+        version: '1.0',
+        short_version: '',
+      }),
+  )
+  .expectBadge({
+    label: 'release',
+    message: 'v1.0',
+  })
+
 t.create('Invalid API Token').get('/invalid/invalid/invalid.json').expectBadge({
   label: 'release',
   message: 'invalid token',