Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #28 #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed issue #28 #29

wants to merge 3 commits into from

Conversation

ok3141
Copy link

@ok3141 ok3141 commented Jun 11, 2014

I also added property POM_DEVELOPER_EMAIL and disabled failing build in case of javadoc errors appears.

@ok3141 ok3141 changed the title Fixed issue #28 and #22 Fixed issues #28 and #22 Jun 11, 2014
@ok3141 ok3141 changed the title Fixed issues #28 and #22 Fixed issue #28 Jun 11, 2014
@cocoahero
Copy link

Shouldn't it be android.sourceSets.main.java.sourceFiles, not android.sourceSets.main.java.source?

Plugin Source Reference: https://android.googlesource.com/platform/tools/base/+/gradle_0.11.1/build-system/gradle/src/main/groovy/com/android/build/gradle/internal/api/DefaultAndroidSourceDirectorySet.java

@ok3141
Copy link
Author

ok3141 commented Jun 11, 2014

maybe :) but .source works for me

@cocoahero
Copy link

Strange that .source works. Unless I'm missing something obvious, that property doesn't exist. XD

@ok3141
Copy link
Author

ok3141 commented Jun 11, 2014

please, correct my patch if I'm wrong. because I'm actually noob in groovy

@cocoahero
Copy link

You're not necessarily wrong, because you're right that it works. I'm just really confused as to why it works. I'm a total groovy noob as well, which is why I wouldn't be surprised if there is some magic somewhere that is adding that .source property.

@cocoahero
Copy link

Also, might be worth while adding in this patch as well, is the auto-linking to the Android documentation for referenced classes.

task androidJavadocs(type: Javadoc) {
    /* ... */
    options {
        linksOffline "http://d.android.com/reference", "${android.sdkDirectory}/docs/reference"
    }
    exclude '**/R.html', '**/R.*.html'
}

@ok3141
Copy link
Author

ok3141 commented Jun 11, 2014

@cocoahero well, you was right. google-guys answered about the same thing: https://code.google.com/p/android/issues/detail?id=71174#c3

danhbear added a commit to danhbear/StickyListHeaders that referenced this pull request Jun 18, 2014
This hasn't been fixed in mainline gradle-mvn-push, so referencing the following commit from a PR that looks like it will be merged:

shamanland/gradle-mvn-push@cc18d56
chrisbanes/gradle-mvn-push#29
chrisbanes/gradle-mvn-push#28
@AlexanderLS
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants