Fix alpha property changes not invalidating (#490)

I forgot to include alpha changes in the invalidation trigger list 🤦 Fixes #489
chrisbanes · Jan 25, 2025 · 122222d · 122222d
1 parent 6cc34d2
commit 122222d
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 2 deletions.
diff --git a/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[28]_20.png b/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[28]_20.png
diff --git a/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[28]_70.png b/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[28]_70.png
diff --git a/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[32]_20.png b/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[32]_20.png
diff --git a/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[32]_70.png b/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha[32]_70.png
diff --git a/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha_20.png b/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha_20.png
diff --git a/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha_70.png b/haze/screenshots/android/HazeScreenshotTest.creditCard_alpha_70.png
diff --git a/haze/screenshots/desktop/HazeScreenshotTest.creditCard_alpha_20.png b/haze/screenshots/desktop/HazeScreenshotTest.creditCard_alpha_20.png
diff --git a/haze/screenshots/desktop/HazeScreenshotTest.creditCard_alpha_70.png b/haze/screenshots/desktop/HazeScreenshotTest.creditCard_alpha_70.png
diff --git a/haze/src/commonMain/kotlin/dev/chrisbanes/haze/HazeEffectNode.kt b/haze/src/commonMain/kotlin/dev/chrisbanes/haze/HazeEffectNode.kt
@@ -731,7 +731,8 @@ internal object DirtyFields {
       Size or
       BackgroundColor or
       Progressive or // TODO: only on Android SDK 32-33
-      Areas
+      Areas or
+      Alpha
 
   fun stringify(dirtyTracker: Bitmask): String {
     val params = buildList {

diff --git a/haze/src/screenshotTest/kotlin/dev/chrisbanes/haze/HazeScreenshotTest.kt b/haze/src/screenshotTest/kotlin/dev/chrisbanes/haze/HazeScreenshotTest.kt
@@ -6,6 +6,7 @@ package dev.chrisbanes.haze
 import androidx.compose.foundation.shape.RoundedCornerShape
 import androidx.compose.runtime.CompositionLocalProvider
 import androidx.compose.runtime.getValue
+import androidx.compose.runtime.mutableFloatStateOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.graphics.Brush
@@ -116,12 +117,23 @@ class HazeScreenshotTest : ScreenshotTest() {
 
   @Test
   fun creditCard_alpha() = runScreenshotTest {
+    var alpha by mutableFloatStateOf(0.5f)
+
     setContent {
       ScreenshotTheme {
-        CreditCardSample(tint = DefaultTint, alpha = 0.5f)
+        CreditCardSample(tint = DefaultTint, alpha = alpha)
       }
     }
+
     captureRoot()
+
+    alpha = 0.2f
+    waitForIdle()
+    captureRoot("20")
+
+    alpha = 0.7f
+    waitForIdle()
+    captureRoot("70")
   }
 
   @Test