Improve performance of random slots page #160
Merged
+261
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
chrisbenincasa
commented
Mar 8, 2024
chrisbenincasa
commented
- Move random slots to their own subcomponent (prevents re-render of whole page when weights change)
- Only update underlying form value on slider commit value (onmouseup)
- Memoize the dropdown portion of each slot row (prevent re-render when sliders change)
- Add CSS animation on non-active sliders, smooth transitions while we're dragging
markdavella
reviewed
Mar 8, 2024
| @@ -639,7 +677,7 @@ export default function RandomSlotEditorPage() { | |||
| <Select | |||
| label="Distribution" | |||
| {...field} | |||
| onChange={(e) => handleDistributionChange(e, field.onChange)} | |||
| // onChange={(e) => handleDistributionChange(e, field.onChange)} | |||
There was a problem hiding this comment.
Just a heads up that this is commented out
There was a problem hiding this comment.
Ah yep, this was on purpose.
chrisbenincasa
force-pushed
the
random-slots-page
branch
from
708ed6c to
50f4b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.