Custom Show Programming Picker - next steps #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbenincasa
force-pushed
the
custom-show-programming-list
branch
from
b135d2e to
ae1e1e0
Compare
markdavella
approved these changes
Mar 13, 2024
| @@ -89,11 +91,7 @@ export default function ProgrammingSelector({ onAddSelectedMedia }: Props) { | |||
| }); | |||
|
|
|||
| useEffect(() => { | |||
| if ( | |||
| mediaSource === 'custom-shows' && | |||
| customShows && | |||
There was a problem hiding this comment.
Q. if useCustomShows fails won't customShows be undefined? or because you pass in the initial data it will always exist?
There was a problem hiding this comment.
yea it will always exist bc of the initialData value being the empty array. if we wanted to handle errors we'd have to check the error field. The query options return a special subtype called DefinedInitialDataOptions which guarantees that the data field doesn't have the | undefined type part
tunarr/web/src/hooks/useCustomShows.ts
Line 13 in ae1e1e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly big overhaul of the way the programming picker to start to generalize over different types of media sources. This lays the groundwork for future features, like adding different media server types (or supporting local files without a media server at all)
This includes the beginning implementation of choosing the dizqueTV concept of 'Custom Shows' in the program picker, just like you could do in dizque. There is sitll some work to be done on actually adding the result of the selected programming to the current channel, since that is still Plex specific. That will happen in a follow-up PR.