Add simple error page - fixes #121 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdavella
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
nite: this file isn't used anywhere
There was a problem hiding this comment.
Thought we might randomly switch between them lmao then I forgot
There was a problem hiding this comment.
nit: there is 1px of nose on the left haha
There was a problem hiding this comment.
lol dammit that is so annoying. I'll fix before merging
web/src/assets/error.png
Outdated
There was a problem hiding this comment.
nit: this file isn't used
There was a problem hiding this comment.
Moving this over to design folder - just since it's the original asset and I dont wanna lose it just yet .
chrisbenincasa
force-pushed
the
error-boundary
branch
from
7f6d752 to
1f78e0f
Compare
chrisbenincasa
force-pushed
the
error-boundary
branch
from
1f78e0f to
2a86023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
Adds a simple error page (screenshot below) at the root router level. Employs a mini-hack to make the error page appear in the overall Layout. The downside to this hack, which is probably something we should think about, is that if the error occurs in the layout (Root) component itself, we'll have an issue rendering this Error page. We could consider a barebones Error Root component; perhaps one that makes no network calls or does anything fancy... but we can do that later.
This also includes a mechanism for helping users file bugs for issues they experiencing by auto-generating a URL specific to the experienced error that prefills contextual details (browser, OS, Tunarr versions, etc).