Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inline Modal to Grid View #195

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Conversation

markdavella
Copy link
Collaborator

Added support for an initial version of an Inline Grid Modal

Preview:
image

Future improvements needed:

  • Performance improvements, especially when initially opening the modal on a new row. I believe this is mostly caused by the transition not knowing the height of the modal as its loading in.
  • Aesthetics
  • Add support for Seasons/Episodes

inline working but janky

inline modal component

fix issue with loading glitch

progress

inline modal working

more work

fix collapse

TS fixes

fix list type display issue

fix issue with alignment and switchig tab values

fix last row modal issue

adjust transitions for modal
@markdavella markdavella merged commit 5095cdd into chrisbenincasa:main Mar 21, 2024
1 check passed
@markdavella markdavella deleted the grid-work branch March 21, 2024 15:25
@chrisbenincasa
Copy link
Owner

Dude this is sick!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants