Make Settings page use controlled components #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
markdavella
commented
Jan 19, 2024
markdavella
commented
- Created utility for detect when strings contain only numbers
- Made nearly all setting form fields controlled
- experimenting with styling of overall setting pages/tabs
| @@ -50,3 +50,7 @@ export const fromStringResolution = ( | |||
| const [h, w] = res.split('x', 1); | |||
| return { widthPx: parseInt(w), heightPx: parseInt(h) }; | |||
| }; | |||
|
|
|||
| export const hasOnlyDigits = (value: string) => { | |||
| return /^-?\d+$/.test(value); | |||
There was a problem hiding this comment.
should prob add the global flag to the regex: /^-?\d+$/g
| { value: 160, string: '3 Seconds' }, | ||
| { value: 180, string: '4 Seconds' }, | ||
| ]; | ||
|
|
||
| const defaultPlexSettings = { |
There was a problem hiding this comment.
these should be available in the dizquetv-types paackage
| setMaxPlayableResolution(event.target.value as string); | ||
| }; | ||
|
|
||
| const [maxDirectStreamBitrate, setMaxDirectStreamBitrate] = useState<string>( |
There was a problem hiding this comment.
super nit - you shouldnt have to be explicit about the type if it is obvious. vscode/typescript will infer the type as string in this case
chrisbenincasa
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.