Skip to content

Commit

Permalink
fetchActions: Also abort on app-internal errors in the initial fetch.
Browse files Browse the repository at this point in the history
As Greg points out [1]:

> Basically it's an internal error in the app. But the user is
> probably better off getting kicked back to the account picker than
> having the loading screen continue indefinitely -- it means at
> least they can try again and see if the issue recurs, or try
> another account and see if they can at least use that.

[1] zulip#4754 (comment)
  • Loading branch information
chrisbobbe committed Jul 15, 2021
1 parent 2b457f6 commit a5228b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/message/fetchActions.js
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ export const doInitialFetch = () => async (dispatch: Dispatch, getState: GetStat
} else if (e instanceof TimeoutError) {
dispatch(initialFetchAbort('timeout'));
} else {
dispatch(initialFetchAbort('unexpected'));
logging.warn(e, {
message: 'Unexpected error during initial fetch and serverSettings fetch.',
});
Expand Down

0 comments on commit a5228b1

Please sign in to comment.