Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert header and popup to mobile-first design #109

Merged
merged 9 commits into from
Nov 1, 2021
Merged

Convert header and popup to mobile-first design #109

merged 9 commits into from
Nov 1, 2021

Conversation

chriscerie
Copy link
Owner

closes #102, closes #108

Converts popup and header to mobile-first design

@chriscerie chriscerie changed the title Convert mobile first Convert header and popup to mobile-first design Nov 1, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1406684889

  • 18 of 27 (66.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 52.25%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/components/Header/MapHeader.tsx 2 3 66.67%
client/src/pages/HomePage/PopupSelected.tsx 3 4 75.0%
client/src/components/BottomPopup.tsx 13 20 65.0%
Files with Coverage Reduction New Missed Lines %
client/src/components/Header/MapHeader.tsx 1 56.25%
Totals Coverage Status
Change from base Build 1400690341: -0.2%
Covered Lines: 198
Relevant Lines: 326
💛 - Coveralls

@chriscerie chriscerie marked this pull request as ready for review November 1, 2021 05:52
@chriscerie chriscerie merged commit 4eee15d into main Nov 1, 2021
@chriscerie chriscerie deleted the convert-mobile-first branch November 1, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popup should be able to drag up on mobile Sidebar should be part of search bar
2 participants
@chriscerie @coveralls