Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display location information in right sticky sidebar #161

Merged
merged 4 commits into from
Dec 3, 2021
Merged

Display location information in right sticky sidebar #161

merged 4 commits into from
Dec 3, 2021

Conversation

jasonem225
Copy link
Contributor

Changed right column into boxes going from top to bottom

@coveralls
Copy link

coveralls commented Nov 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1534169591

  • 3 of 6 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.6%) to 41.354%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/components/Header/LocationHeader.tsx 1 2 50.0%
client/src/pages/LocationPage/index.tsx 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
client/src/pages/LocationPage/RightColumnDetails.tsx 1 4.35%
Totals Coverage Status
Change from base Build 1534003694: -2.6%
Covered Lines: 313
Relevant Lines: 581
💛 - Coveralls

@chriscerie chriscerie marked this pull request as draft November 19, 2021 07:20
@chriscerie chriscerie marked this pull request as ready for review December 3, 2021 07:10
@chriscerie chriscerie changed the title Edit Right Column Display location information in right sticky sidebar Dec 3, 2021
@chriscerie chriscerie merged commit fb992eb into main Dec 3, 2021
@chriscerie chriscerie deleted the edit-right-column branch December 3, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscerie chriscerie chriscerie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonem225 @coveralls @chriscerie