Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image upload option in review page #182

Merged
merged 22 commits into from
Dec 4, 2021
Merged

Add image upload option in review page #182

merged 22 commits into from
Dec 4, 2021

Conversation

chriscerie
Copy link
Owner

closes #181

@chriscerie chriscerie marked this pull request as draft November 21, 2021 08:41
@coveralls
Copy link

coveralls commented Nov 21, 2021

Pull Request Test Coverage Report for Build 1537650240

  • 22 of 109 (20.18%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.5%) to 38.43%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/components/Header/ProfileIcon.tsx 3 4 75.0%
client/src/pages/WriteReviewPage/PhotoPopup.tsx 5 14 35.71%
client/src/api/GetBase64.ts 3 15 20.0%
src/routes/reviews.ts 1 29 3.45%
client/src/pages/WriteReviewPage/index.tsx 8 45 17.78%
Files with Coverage Reduction New Missed Lines %
client/src/pages/LocationPage/ReviewSection/Review.tsx 1 36.0%
client/src/pages/WriteReviewPage/index.tsx 6 17.72%
Totals Coverage Status
Change from base Build 1537185017: -2.5%
Covered Lines: 345
Relevant Lines: 689

💛 - Coveralls

@chriscerie chriscerie marked this pull request as ready for review December 3, 2021 23:01
@chriscerie chriscerie merged commit c05e687 into main Dec 4, 2021
@chriscerie chriscerie deleted the add-image-upload branch December 4, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image upload in review page
2 participants