Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rooms list to location edit page and render rooms in moderation page #190

Merged
merged 4 commits into from
Dec 3, 2021

Conversation

birded
Copy link
Contributor

@birded birded commented Dec 1, 2021

Can dynamically add fields for classrooms in the location edit page, but isn't connected to the backend.

@birded birded marked this pull request as ready for review December 1, 2021 06:31
@chriscerie chriscerie changed the title Add frontend for classroom field in location edit page Add rooms list to location edit page and render rooms in moderation page Dec 3, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1533993687

  • 5 of 33 (15.15%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.3%) to 43.984%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/pages/ModerationPage/Submission.tsx 0 1 0.0%
client/src/pages/LocationEditPage/index.tsx 5 18 27.78%
src/routes/locations.ts 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
client/src/pages/LocationEditPage/index.tsx 1 27.69%
src/routes/locations.ts 1 30.0%
Totals Coverage Status
Change from base Build 1533137955: -2.3%
Covered Lines: 311
Relevant Lines: 576

💛 - Coveralls

@chriscerie chriscerie merged commit c4fbf78 into main Dec 3, 2021
@chriscerie chriscerie deleted the add-classroom-field branch December 3, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants