Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create share feature in location page #199

Merged
merged 4 commits into from
Dec 4, 2021
Merged

Create share feature in location page #199

merged 4 commits into from
Dec 4, 2021

Conversation

mpbonham
Copy link
Contributor

@mpbonham mpbonham commented Dec 3, 2021

Created a share feature for individual locations. Allows for email sharing and a copyable link

@mpbonham mpbonham linked an issue Dec 3, 2021 that may be closed by this pull request
Create share feature #178
Closed
@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1538270963

  • 12 of 29 (41.38%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 38.935%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/pages/LocationPage/LeftColumnDetails.tsx 2 7 28.57%
client/src/pages/LocationPage/SharePopup.tsx 10 22 45.45%
Files with Coverage Reduction New Missed Lines %
client/src/pages/LocationPage/LeftColumnDetails.tsx 1 52.38%
Totals Coverage Status
Change from base Build 1538250304: 0.07%
Covered Lines: 387
Relevant Lines: 778
💛 - Coveralls

@chriscerie chriscerie changed the title Created Share Feature Create share feature in location page Dec 3, 2021
@chriscerie chriscerie merged commit 707b79d into main Dec 4, 2021
@chriscerie chriscerie deleted the share-feature branch December 4, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscerie chriscerie chriscerie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create share feature
3 participants
@mpbonham @coveralls @chriscerie