Skip to content
This repository has been archived by the owner on Jul 13, 2020. It is now read-only.

GHC 8.4.1 support #538

Merged
merged 10 commits into from
Mar 13, 2018
Merged

GHC 8.4.1 support #538

merged 10 commits into from
Mar 13, 2018

Conversation

chrisdone
Copy link
Collaborator

Opening PR for CI check.

@chrisdone
Copy link
Collaborator Author

Seems like we can't build Intero on Windows yet because the network package doesn't build on Windows: https://ci.appveyor.com/project/chrisdone/intero/build/1.0.253#L34325

34323    [2 of 9] Compiling Network.Socket.Types ( .stack-work\dist\893fbf7f\build\Network\Socket\Types.hs, .stack-work\dist\893fbf7f\build\Network\Socket\Types.o )
34324    
34325    C:\Users\appveyor\AppData\Local\Temp\1\stack2744\network-2.6.3.4\Network\Socket\Types.hsc:764:16: error:
34326        parse error on input `CALLCONV'
34327        |
34328    764 | foreign import CALLCONV unsafe "ntohs" ntohs :: Word16 -> Word16
34329        |                ^^^^^^^^

@chrisdone
Copy link
Collaborator Author

Opened an issue haskell/network#313 for the network package on Windows.

Otherwise, Windows and OS X both pass the build. Windows isn't going to build until the network package is fixed anyway, so I'm merging this in with GHC 8.4 on AppVeyor commented out.

@chrisdone chrisdone merged commit 324362b into master Mar 13, 2018
@chrisdone chrisdone deleted the ghc_8.4 branch March 13, 2018 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant