Some updates that makes this library to work with the newest React versions + some bug fixes #92
+2,066
−966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I saw your comment on this closed PR that explained why you don't want to upgrade library's React related specifications to ensure its compatibility with older React versions. But I was wondering if it is possible to have a seperate version of this library that supports newer react versions since the current library crashes on newer react versions. If possible, I could help with that! Thanks for the time reading this~ |
|
I think this library could probably be updates to both not crash and work on older react versions :D I plan on circling back to this library soon as I need it for an upcoming project. In the meantime I'm happy to accept PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: Answer from StackOverflow
Marker(title & subtitle) andMap(tintColor). I have added them.