Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some setting changes not saved to workflow when swapping #375

Closed
chrisgoringe opened this issue Nov 22, 2024 · 5 comments
Closed

Some setting changes not saved to workflow when swapping #375

chrisgoringe opened this issue Nov 22, 2024 · 5 comments
Labels
bug Something isn't working completed on branch
Milestone

Comments

@chrisgoringe
Copy link
Owner

See #363 (comment)

@chrisgoringe chrisgoringe added this to the Bugfix milestone Nov 22, 2024
@chrisgoringe chrisgoringe added the bug Something isn't working label Nov 22, 2024
@LukeG89
Copy link

LukeG89 commented Nov 22, 2024

Found it!
It's not just the swapping, it's the last edited title that is not saved.

Step to reproduce:

  • Edit a couple of groups
  • Save and close the workflow
  • Reopen it: the last group tab you renamed has the previous name

I tested this on 1.3.44 frontend with all other extensions disabled.

Last-Edited-Group.mp4

@chrisgoringe
Copy link
Owner Author

chrisgoringe commented Nov 26, 2024

There's an issue in the ComfyUI front end. I've raised an issue there:

Comfy-Org/ComfyUI_frontend#1690

@chrisgoringe
Copy link
Owner Author

I've got a workaround in... bit of a hack...

On dev

@LukeG89
Copy link

LukeG89 commented Nov 26, 2024

Yeah, seems to work!

There is only one small exception when editing subgroups: you must save or move a node to apply the change.
But I guess that in 1.4.12 frontend everything will work fine, I see they merged a PR to fix your issue.

@LukeG89
Copy link

LukeG89 commented Nov 26, 2024

Ok, now in 1.4.13 is perfectly working in every situation! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed on branch
Projects
None yet
Development

No branches or pull requests

2 participants