Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md and make the example work #1046

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Update README.md and make the example work #1046

merged 2 commits into from
Nov 22, 2019

Conversation

salmasian
Copy link
Contributor

Fixes #1042

@salmasian
Delete example
634c702 
The example in README.md is sufficient
@salmasian
Making the example in README.md work
b4bd3bd 
Also expanding the example to demonstrate how the id parameter is used
omkartapale
omkartapale approved these changes Nov 22, 2019
View reviewed changes
Copy link

@omkartapale omkartapale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Now example is complete.
Just one or two small changes. Use self::HTTP_OK instead 200 response http code, and self::HTTP_NOT_FOUND instead 404 response http code.

@chriskacerguis chriskacerguis merged commit b471a60 into chriskacerguis:master Nov 22, 2019
@chriskacerguis
Copy link
Owner

Thanks for the help!

@chriskacerguis chriskacerguis mentioned this pull request Nov 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkartapale omkartapale omkartapale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

README.md correction
3 participants
@salmasian @chriskacerguis @omkartapale