fix: minNotional (#623)

chrisleekr · Apr 12, 2023 · fdd1421 · fdd1421
1 parent ca00cd8
commit fdd1421
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,9 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
-## [Unreleased]
+## [0.0.98] - 2023-04-13
 
 - Added the prefix to environment parameter for `TRADINGVIEW` related - [#616](https://github.com/chrisleekr/binance-trading-bot/pull/616)
+- Fixed the issue with minNotional - [#623](https://github.com/chrisleekr/binance-trading-bot/pull/623)
 
 ## [0.0.97] - 2023-03-21
 

diff --git a/app/cronjob/trailingTradeHelper/__tests__/fixtures/binance-exchange-info.json b/app/cronjob/trailingTradeHelper/__tests__/fixtures/binance-exchange-info.json
@@ -65,10 +65,12 @@
           "stepSize": "0.01000000"
         },
         {
-          "filterType": "MIN_NOTIONAL",
+          "filterType": "NOTIONAL",
           "minNotional": "10.00000000",
-          "applyToMarket": true,
-          "avgPriceMins": 5
+          "applyMinToMarket": true,
+          "maxNotional": "10000.00000000",
+          "applyMaxToMarket": false,
+          "avgPriceMins": 1
         },
         {
           "filterType": "ICEBERG_PARTS",

diff --git a/app/cronjob/trailingTradeHelper/common.js b/app/cronjob/trailingTradeHelper/common.js
@@ -62,14 +62,23 @@ const cacheExchangeSymbols = async logger => {
   const { symbols } = exchangeInfo;
 
   const exchangeSymbols = symbols.reduce((acc, symbol) => {
+    // For backward compatibility, MIN_NOTIONAL is deprecated.
     const minNotionalFilter = _.find(symbol.filters, {
       filterType: 'MIN_NOTIONAL'
     });
+
+    // New filter type is NOTIONAL.
+    const notionalFilter = _.find(symbol.filters, {
+      filterType: 'NOTIONAL'
+    });
+
     acc[symbol.symbol] = {
       symbol: symbol.symbol,
       status: symbol.status,
       quoteAsset: symbol.quoteAsset,
-      minNotional: parseFloat(minNotionalFilter.minNotional)
+      minNotional: minNotionalFilter
+        ? parseFloat(minNotionalFilter.minNotional)
+        : parseFloat(notionalFilter.minNotional)
     };
 
     return acc;