Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP to slack message when someone fails to authenticate + log file for fail2ban #281

Closed
caebwallace opened this issue Aug 19, 2021 · 2 comments · Fixed by #295
Closed

Add IP to slack message when someone fails to authenticate + log file for fail2ban #281

caebwallace opened this issue Aug 19, 2021 · 2 comments · Fixed by #295
Labels
enhancement New feature or request

Comments

@caebwallace
Copy link
Contributor

As I've installed the bot on a VPS with a protection password, I start to have someone that try to login to the bot.
The message is currently sent to my slack channel :

Binance Webserver (08:20:57.978):
The bot failed to authenticate.
- Entered password: Elino1973!

Describe the solution you'd like

  • Would be useful if the IP of the client can be added to the slack message (authentication success or fail)
  • Add an utf8 icon like ✅ or ❌
  • A nice to have could a log file that can be analyzed by fail2ban and as this, we can have have a policy to ban IP that try to bruteforce the authentication.

Context

  • Docker container through docker-compose on debian VPS
  • v0.76
@caebwallace caebwallace added the enhancement New feature or request label Aug 19, 2021
@chrisleekr
Copy link
Owner

Interesting.

Let me see what I can do.

@caebwallace
Copy link
Contributor Author

I'm doing it, working on fail2ban rule and it's ok :)
Logfile is stored in /logs/auth.log (it's a mess to catch docker log files)

caebwallace pushed a commit to caebwallace/binance-trading-bot that referenced this issue Aug 28, 2021
feat(auth): improve slack messages + add fail2ban logfile chrisleekr#281
4ab5b54
@caebwallace caebwallace mentioned this issue Aug 28, 2021
Merged
chrisleekr added a commit that referenced this issue Sep 3, 2021
@caebwallace @chrisleekr
feat(auth): improve slack messages #281 (#287)
f53033e 
Co-authored-by: Caeb WALLACE <null>
Co-authored-by: Chris Lee <git@chrislee.kr>
@caebwallace caebwallace mentioned this issue Sep 3, 2021
Closed
@chrisleekr chrisleekr mentioned this issue Sep 3, 2021
Merged
@chrisleekr chrisleekr linked a pull request Sep 3, 2021 that will close this issue
feat(auth): support rate limiter to prevent brute force #295
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(auth): support rate limiter to prevent brute force chrisleekr/binance-trading-bot
2 participants
@chrisleekr @caebwallace