Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui improvements #452

Conversation

uhliksk
Copy link
Contributor

@uhliksk uhliksk commented Aug 1, 2022

Description

  • Fix pagination is showing more pages than actually used and is not compliant with standard pagination methods.
  • Add support to show up to all 12 columns on ultra wide monitors.
  • Unexecuted grid trades compacted in lists with more than 10 items.
  • Object for pagination consistent across the application.
  • Fix unnecessary text wrapping if there is enough space to print a text.
  • Show Action time in local time.
  • Changed time format for logs to 24 hours to be consistent within application.

Related Issue

#437, #440, #442, #444, #446

Motivation and Context

The fix will improve the user experience.

How Has This Been Tested?

Tested on UHD display and on wide multi monitor setup with tens of grid trades in various states.

Screenshots (if appropriate):

Buttons are visible for available pages only:

image

Ultra wide monitor support:

image

Compact grid trade list:

image

Pagination object at top and bottom with up to 8 numbered buttons:

image

Even a very wide texts are no longer wrapped after the fix is applied:

image

Columns are consistent after the fix is applied:

image

@chrisleekr
Copy link
Owner

chrisleekr commented Aug 1, 2022

@uhliksk
Thanks for merging PRs. Amazing contributions!

I will review+test after #448 is merged.
Actually, looking at the changes, it looks like there will be no/less conflict with #448.
I will try to test it out tomorrow or during this week and it may merge prior to #448.

I am very lack of time, so please bear with me. :)

Thanks!

@chrisleekr chrisleekr added the enhancement New feature or request label Aug 1, 2022
@uhliksk uhliksk force-pushed the fix-ui-pagination-compact-wrapping-wide-monitor branch 2 times, most recently from 588da2c to 5a83ba3 Compare August 1, 2022 20:29
@uhliksk
Copy link
Contributor Author

uhliksk commented Aug 2, 2022

@chrisleekr I understand. I made some minor changes in the meanwhile to even improve this PR.

@uhliksk uhliksk force-pushed the fix-ui-pagination-compact-wrapping-wide-monitor branch from 5a83ba3 to 89f558c Compare August 2, 2022 10:12
@chrisleekr
Copy link
Owner

chrisleekr commented Aug 2, 2022

@uhliksk

This is a very good fix.
I also was very annoyed by pagination, but your fix made me comfortable. haha.
And CSS fix. 👍

I just have one comment. Other changes are good to go!

@uhliksk uhliksk force-pushed the fix-ui-pagination-compact-wrapping-wide-monitor branch 4 times, most recently from 4d39ff9 to 8c5a566 Compare August 3, 2022 17:38
@uhliksk uhliksk force-pushed the fix-ui-pagination-compact-wrapping-wide-monitor branch from 8c5a566 to c326fe6 Compare August 3, 2022 18:03
@chrisleekr chrisleekr merged commit f615b0b into chrisleekr:master Aug 4, 2022
@chrisleekr
Copy link
Owner

@uhliksk

It's merged!

Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants