Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add advanced chart link to Tradingview section #525

Merged
merged 1 commit into from
Oct 10, 2022
Merged

feat: add advanced chart link to Tradingview section #525

merged 1 commit into from
Oct 10, 2022

Conversation

rando128
Copy link
Contributor

Is your proposal related to a problem?

The existing Tradingview link in the coin wrapper view opens the browser to the Technical Analysis summary. If I want to access the advanced chart instead, I have to do it from TV TA page.

Describe the solution you'd like

Ideally the coin wrapper view should offer both options:

  • access to TV TA page
  • access to TV advanced chart

Describe alternatives you've considered

Here is an example of proposed UI:
Screenshot 2022-10-09 at 19 10 18

@chrisleekr
Copy link
Owner

Thank you for your contribution @rando128

I merge in. 👍

@chrisleekr chrisleekr merged commit eb33449 into chrisleekr:master Oct 10, 2022
@rando128 rando128 deleted the feat/add-tradingview-detailed-chart-access branch October 11, 2022 07:46
@peweb
Copy link

peweb commented Oct 14, 2022

@chrisleekr

How to apply this change? git pull all files updated. Manually checked public/js/CoinWrapperTradingView.js and I see new code there but inretface is not updated

image

I restared the server and cleared cache but still I cant see the changes.

Can you help?

Thanks!

@rando128
Copy link
Contributor Author

@peweb, this feature has been merged but not released yet, so you will have to run the bot in dev mode: docker-compose up -d --build

@chrisleekr
Copy link
Owner

chrisleekr commented Oct 14, 2022

Or you can use development tag, which always has a master build.

Update your docker-compose.server.yml

chrisleekr/binance-trading-bot:tradingview-development
chrisleekr/binance-trading-bot:development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants