-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added multiple tradingview indicators #539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #539 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 91 92 +1
Lines 3505 3554 +49
Branches 610 607 -3
=========================================
+ Hits 3505 3554 +49 ☔ View full report in Codecov by Sentry. |
Looks cool! I also use the technique of multiple Tradingview confirmations in my own bot and have it live now for about half a year. It never gave me any problems with rate limiting. If you are interested, happy to share, but I thought this was not the place to advertise my own work :) |
@eppenga Oh, if you can share your code, I am happy to take it as a reference. So I am thinking of refactoring the code to not harm the performance. |
Sure, gladly, please see: https://github.com/eppenga/goldstar-crypto-trading-bot It's just a simple PHP script that buys and sells based on either signals or as a gridbot. Personally I use it as a gridbot with 4-fold TradingView confirmation continuously on four different pairs and query every 15 seconds. I think the main difference regarding TradingView is that I think you query TradingView all the time and I only do so when a BUY is imminent. So far I have never experiences issues with TradingView, not sure if they have rate limiting, never saw it. |
Before merging,
|
Explanation of TradingView is here - https://github.com/chrisleekr/binance-trading-bot/wiki/TradingView |
Hi @chrisleekr, when do you plan to make it into an official 0.0.99 release? |
Hi @rando128 I am not sure. All packages are very outdated and I will need to spend some time to update all packages. It should work with the |
Description
This PR is providing multiple TradingView indicators.
Warnings: Please do a backup before upgrading. It may break due to migrations. If it breaks, please let me know.
Changes:
{symbol:'global'}
toslack.sendMessage
to make sure not flooding with duplicate messages.Caveats:
Related Issue
#438
Motivation and Context
The TradingView is providing the indicator per interval.
At the moment, the bot only monitors a single TradingView interval, which is ok.
But the trend can be changed very quickly before new technical analysis results.
How Has This Been Tested?
It's been running on my server.
However, this requires intensive test before releasing.
Screenshots (if appropriate):