Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download log file directly #561

Merged
merged 2 commits into from
Jan 2, 2023
Merged

fix: download log file directly #561

merged 2 commits into from
Jan 2, 2023

Conversation

chrisleekr
Copy link
Owner

@chrisleekr chrisleekr commented Jan 1, 2023

Description

This fix is to make log files to be downloaded directly from the web server rather than using blob.

Related Issue

#537

Motivation and Context

If the log file is enormous, the export function throws an Invalid string length error.
To avoid the error, create the log file in the public folder and download it directly from the web server.
To avoid out of the disk space, it will only keep the last 10 log files.

How Has This Been Tested?

Screenshots (if appropriate):

@chrisleekr chrisleekr added the bug Something isn't working label Jan 1, 2023
@chrisleekr chrisleekr linked an issue Jan 1, 2023 that may be closed by this pull request
@chrisleekr chrisleekr changed the title fix: make log file to be downloaded directly fix: download log file directly Jan 1, 2023
@chrisleekr chrisleekr self-assigned this Jan 1, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3d12ad7) compared to base (b341b31).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #561   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           92        92           
  Lines         3400      3419   +19     
  Branches       571       574    +3     
=========================================
+ Hits          3400      3419   +19     
Impacted Files Coverage Δ
...ntend/webserver/handlers/grid-trade-logs-export.js 100.00% <100.00%> (ø)
app/server-frontend.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisleekr chrisleekr merged commit 991102a into master Jan 2, 2023
@chrisleekr chrisleekr mentioned this pull request Jan 2, 2023
@chrisleekr chrisleekr deleted the fix/export-log branch May 4, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't export pair trading logs
2 participants