Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace static methods in some transformers #110

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

premsrii
Copy link
Collaborator

This PR replaces some of the inner static methods that are used with pl.DataFrame.apply(), with suitable alternatives. The purpose is to improve the pytest code coverage, which currently ignores these functions.

@premsrii premsrii requested a review from chrislemke April 20, 2023 17:12
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #110 (a3e8121) into develop (c493677) will decrease coverage by 3.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #110      +/-   ##
===========================================
- Coverage    99.42%   96.40%   -3.02%     
===========================================
  Files            8        8              
  Lines          519      501      -18     
===========================================
- Hits           516      483      -33     
- Misses           3       18      +15     
Impacted Files Coverage Δ
src/sk_transformers/__init__.py 100.00% <100.00%> (ø)
src/sk_transformers/datetime_transformer.py 100.00% <100.00%> (ø)
src/sk_transformers/generic_transformer.py 100.00% <100.00%> (+0.52%) ⬆️
src/sk_transformers/number_transformer.py 100.00% <100.00%> (ø)
src/sk_transformers/string_transformer.py 84.07% <100.00%> (-14.42%) ⬇️
src/sk_transformers/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@premsrii premsrii closed this Apr 21, 2023
@premsrii premsrii reopened this Apr 21, 2023
@premsrii premsrii merged commit fa6215d into develop Apr 21, 2023
@premsrii premsrii deleted the fix_codecov branch April 21, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants