Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for prepare_categorical_data #5

Merged
merged 27 commits into from
Sep 25, 2022
Merged

Add unit tests for prepare_categorical_data #5

merged 27 commits into from
Sep 25, 2022

Conversation

premsrii
Copy link
Collaborator

This PR adds unit tests for the function prepare_categoriccal_data(). The function is also modified to handle only non-numerical data.

@premsrii premsrii requested a review from chrislemke September 24, 2022 16:16
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
feature_reviser/utils.py Show resolved Hide resolved
feature_reviser/utils.py Show resolved Hide resolved
@premsrii premsrii requested a review from chrislemke September 24, 2022 22:00
@chrislemke
Copy link
Owner

Looks good so far. Could you check if all unit tests pass on your machine? There seems to be an issue with the test on the CI and I just want to make sure everything runs. And please pull all changes from main before running the tests. Thanks!

@premsrii
Copy link
Collaborator Author

Looks good so far. Could you check if all unit tests pass on your machine? There seems to be an issue with the test on the CI and I just want to make sure everything runs. And please pull all changes from main before running the tests. Thanks!

All tests are passing now. I have modified other files because of changes in prepare_categorical_data().

@chrislemke
Copy link
Owner

@premsrii If you need help resolving the merge conflict. We could do it together.

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #5 (646570d) into main (ed98f9a) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   94.31%   94.82%   +0.50%     
==========================================
  Files           8        8              
  Lines         352      348       -4     
==========================================
- Hits          332      330       -2     
+ Misses         20       18       -2     
Impacted Files Coverage Δ
feature_reviser/feature_selection/reviser.py 93.75% <100.00%> (ø)
feature_reviser/feature_selection/selector.py 90.47% <100.00%> (ø)
feature_reviser/utils.py 100.00% <100.00%> (+6.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@premsrii premsrii merged commit 4950acf into chrislemke:main Sep 25, 2022
@premsrii premsrii deleted the prem branch September 25, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants