making tot_student field mandatory #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrrowland
approved these changes
Aug 17, 2021
chrisrrowland
added a commit
that referenced
this pull request
Sep 1, 2021
* Creatated AddUMUsers page w/ stepper * Move step content to functions * Wire up get course sections w/ create sections FE * Added functionless CreateSectionWidget some AddUMUsers layout * Start of a section selector * Small layout correction * Loading spinner and selection callback function for section list * Sort section list alphabetically * Work in progress. Create section widget * Enter keys to create section * Fix a typescript warning. Disable submit while processing. * making tot_student field mandatory (#4) * Starting work on upload section * need a minHeight so backdrop has somewhere to go * Initial work with confirmation * Handle parse errors validate uniqnames and roles * Show an error if can't load sections from canvas * Fix regex * Multiselect support * Get rid of some unnecessary state * Select newly created section * Changed uniqname references to login id per requirement change no longer applying uniqname regex * Make cancel button functional * remove some log statements * Preemptive assault on variable names * Fix error icon color * Added missing newline * Search within sections * Add clear button * A little room to breathe above section selctor * Cleaner clear button on section search * Fix Role being labled as Section Name * Section subtext 'students' instead of 'users' * Add a small margin below section list * Don't sort enrollments * Fix wrong line number in error * remove log statement * Fix floating swagger link * Fix non functional spelling error * Use enums in switch statement. * Remove a comment * change bulk um enroll example file name * never ever have a line of currently unreferenced code * Spacing between section name input and button * Change hint text * Add helpful tooltip * Make 'Or select one available section to add users' farther away * improve responsiveness of create section widget * New tooltip text * Change the name again. I'm sure it wont change again 🤪 * Toast on parsing error * So I can put this back in again later Co-authored-by: Pushyami Gundala <pushyamig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the total_student not optional