Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect error message shown due to Spectre.Console parsing #585

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

christianhelle
Copy link
Owner

This relates to #583

This pull request includes a change to improve the error handling in the ExecuteAsync method of the GenerateCommand class. The main change involves simplifying the way exceptions are logged to the console.

Error handling improvement:

  • src/Refitter/GenerateCommand.cs: Simplified the exception logging by using AnsiConsole.WriteException to print the exception details instead of manually formatting the message, exception type, and stack trace.

@christianhelle christianhelle added enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code labels Jan 14, 2025
@christianhelle christianhelle self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (599ebf1) to head (1edc5f3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          53       53           
  Lines        2612     2612           
=======================================
  Hits         2479     2479           
  Misses         98       98           
  Partials       35       35           
Flag Coverage Δ
unittests 94.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit adf750e into main Jan 14, 2025
10 checks passed
@christianhelle christianhelle deleted the fix-error-message-parsing branch January 14, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request .NET Pull requests that contain changes to .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant