Prevent 'undefined' from being appended to API resource URL when using custom Axios instance

[slurmulon]

Problem

When using a custom axios instance it's possible for the final resource URL to include an unwanted undefined string literal, like so:

Unwanted result: http://localhost:8080/undefined/v1/user
Desired result: http://localhost:8080/v1/user

This only happens when using a custom axios instance because, in this case, the user typically avoids setting the core baseURL property and instead only sets the property in axios. Ideally users should only set one or the other.

Solution

This proposed change corrects the problem by introducing the normalizedBaseURL getter.

This method explicitly checks for and utilizes the baseURL value defined in axios.

[slurmulon]

I'm not sure if this belongs in v2 or master, seems like probably master instead..?

[christianmalek]

Hello @slurmulon,

thanks for your PR. I really appreciate it!

Currently master branch equals v1. So you PR'ed properly to v2. :)

I'll investigate the PR later this week and let you know when I'm merging it.

[slurmulon]

@christianmalek Cheers, no problem at all. Thank you for all of your awesome work!

[christianmalek]

@slurmulon It's merged and I updated the README.

[slurmulon]

@christianmalek Awesome, thanks!